SOLR-9280 - make nodeName a configurable parameter in solr.xml #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes live nodeName configurable via solr.xml by setting
To test, I randomly set nodeName in
AbstractFullDistribZkTestBase
for complete coverage.I've gotten all tests to pass both when ALWAYS using a random nodeName and with it being set randomly. However during one particular run I got a test failure for the following:
ant test -Dtestcase=TestReqParamsAPI -Dtests.method=test -Dtests.seed=391BC4715DE8C2FE -Dtests.slow=true -Dtests.locale=pl-PL -Dtests.timezone=Asia/Chungking -Dtests.asserts=true -Dtests.file.encoding=UTF-8
but am unable to reproduce the issue in eclipse and at this time am not sure if its related