LUCENE-9069: Prevent memory leaks in PerFieldAnalyzerWrapper #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By overriding the 'close' method. Otherwise nothing will close the defaultAnalyzer as well as all the fieldAnalyzers.
|
Hi, looking at some old PRs. For better visibility, please go to https://issues.apache.org/jira/projects/LUCENE and file a JIRA issue for this bug. Then update the title of this PR with the JIRA-id and add a link to the JIRA in a comment. Then they will be linked. And a committer will likely merge it for you! |
boris-petrov
changed the title
|
Here is a link to the JIRA issue. Thanks! |
markrmiller
added a commit
that referenced
this pull request
Jul 14, 2020
markrmiller
added a commit
that referenced
this pull request
Jul 14, 2020
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By overriding the 'close' method. Otherwise nothing will close the defaultAnalyzer as well as all the fieldAnalyzers.