#152 - Try harder.

apache · Jul 14, 2020 · f36d35a · f36d35a
1 parent 68c3ffc
commit f36d35a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/solr/core/src/java/org/apache/solr/core/CoreContainer.java b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
@@ -193,7 +193,7 @@ public CoreLoadFailure(CoreDescriptor cd, Exception loadFailure) {
 
   private volatile UpdateShardHandler updateShardHandler;
 
-  private volatile static ThreadPoolExecutor solrCoreLoadExecutor;
+  public volatile static ThreadPoolExecutor solrCoreLoadExecutor;
 
   private final OrderedExecutor replayUpdatesExecutor;
 

diff --git a/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java b/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
@@ -34,7 +34,9 @@
 import org.apache.solr.client.solrj.impl.HttpClientUtil;
 import org.apache.solr.cloud.autoscaling.ScheduledTriggers;
 import org.apache.solr.common.TimeTracker;
+import org.apache.solr.common.util.ExecutorUtil;
 import org.apache.solr.common.util.ObjectReleaseTracker;
+import org.apache.solr.core.CoreContainer;
 import org.apache.solr.servlet.SolrDispatchFilter;
 import org.apache.solr.util.ExternalPaths;
 import org.apache.solr.util.RandomizeSSL;
@@ -320,12 +322,16 @@ public void checkSyspropForceBeforeAssumptionFailure() {
   @AfterClass
   public static void afterSolrTestCase() throws Exception {
     try {
-    if (suiteFailureMarker.wasSuccessful()) {
-      // if the tests passed, make sure everything was closed / released
-      String orr = ObjectReleaseTracker.checkEmpty();
-      ObjectReleaseTracker.clear();
-      assertNull(orr, orr);
-    }} finally {
+      ExecutorUtil.shutdownAndAwaitTermination(CoreContainer.solrCoreLoadExecutor);
+      CoreContainer.solrCoreLoadExecutor = null;
+
+      if (suiteFailureMarker.wasSuccessful()) {
+        // if the tests passed, make sure everything was closed / released
+        String orr = ObjectReleaseTracker.checkEmpty();
+        ObjectReleaseTracker.clear();
+        assertNull(orr, orr);
+      }
+    } finally {
       ObjectReleaseTracker.OBJECTS.clear();
       TestInjection.reset();
     }
@@ -352,7 +358,7 @@ public static void afterSolrTestCase() throws Exception {
       Long tooLongTime = 0L;
       try {
         synchronized (TimeTracker.CLOSE_TIMES) {
-          Map<String,TimeTracker> closeTimes = TimeTracker.CLOSE_TIMES;
+          Map<String, TimeTracker> closeTimes = TimeTracker.CLOSE_TIMES;
           for (TimeTracker closeTime : closeTimes.values()) {
 //              if (closeTime.getClazz() == SolrCore.class) {
 //                continue;