Skip to content
This repository has been archived by the owner on Dec 19, 2020. It is now read-only.

add throwable information to xml layout if present #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add throwable information to xml layout if present #12

wants to merge 1 commit into from

Conversation

chbiel
Copy link

@chbiel chbiel commented May 19, 2014

Include the throwable information, that are present in the LoggerLoggingEvent, into the xml layout if present

Copy link

@kategray kategray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fairly clean, but I'd like to see unit testing to ensure that the output is what it should be.

@rgoers I can put one together if you'd like, but I'd suggest not approving this until there's a unit test for it.

@rgoers
Copy link
Member

rgoers commented Oct 29, 2019

OK. Got ahead and create the unit test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants