Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVY-986][SERVER] Adding null pointer check for SessionInfo #412

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[LIVY-986][SERVER] Adding null pointer check for SessionInfo #412

merged 1 commit into from
Aug 18, 2023

Conversation

askhatri
Copy link
Contributor

What changes were proposed in this pull request?

[LIVY-986][SERVER] Adding null pointer check for SessionInfo

What changes were proposed in this pull request?

Adding null check for SessionInfo parameters "conf", "archives", "jars", "pyFiles" and "files"
JIRA: https://issues.apache.org/jira/browse/LIVY-986

How was this patch tested?

Tested manually by running session recovery.

Please review https://livy.incubator.apache.org/community/ before opening a pull request.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #412 (b2d0dc7) into master (b175ba1) will decrease coverage by 37.02%.
Report is 1 commits behind head on master.
The diff coverage is 44.44%.

@@              Coverage Diff              @@
##             master     #412       +/-   ##
=============================================
- Coverage     65.61%   28.60%   -37.02%     
+ Complexity      952      379      -573     
=============================================
  Files           103      103               
  Lines          6044     6059       +15     
  Branches        911      916        +5     
=============================================
- Hits           3966     1733     -2233     
- Misses         1534     3973     +2439     
+ Partials        544      353      -191     
Files Changed Coverage Δ
...server/interactive/InteractiveSessionServlet.scala 56.12% <44.44%> (-6.02%) ⬇️

... and 86 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gyogal gyogal merged commit 4cee47d into apache:master Aug 18, 2023
3 checks passed
@askhatri askhatri deleted the LIVY-986 branch August 18, 2023 12:54
jimenefe pushed a commit to onedot-data/incubator-livy that referenced this pull request Oct 15, 2024
)

We need to add a null check for SessionInfo in InteractiveSessionServlet.scala to avoid an exception that might occur during a Livy upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants