Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1131] test migration from V7 to code generation-5 #3559

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Abhitocode
Copy link
Contributor

@Abhitocode Abhitocode commented Jun 10, 2024

In addition to previous changes associated,
migrated some BPMN processes which are being compiled using legacy v7 to code generation approach, using new branch incubator-kie-issues-1131-5

The tests can be identified by referring to Activitytest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java

Closes apache/incubator-kie-issues#1131.

@Abhitocode Abhitocode changed the title [incubator-kie-issues-1131] test migration from V7 to code generation-3 [incubator-kie-issues-1131] test migration from V7 to code generation-5 Jun 10, 2024
@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-5 branch 2 times, most recently from cd920c6 to 42ca65c Compare June 18, 2024 15:45
@elguardian
Copy link
Contributor

@Abhitocode plz fix the conflict

@kie-ci3
Copy link
Contributor

kie-ci3 commented Jul 17, 2024

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3559 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3559/5/display/redirect

Test results:

  • PASSED: 2853
  • FAILED: 1

Those are the test failures:

io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReload Condition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elguardian elguardian marked this pull request as ready for review July 17, 2024 09:04
@elguardian
Copy link
Contributor

@martinweiler or @pefernan do you mind to have a look

@pefernan pefernan merged commit 463fafd into apache:main Jul 22, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate process test migration from v7 legacy runtime to code generation
4 participants