-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues-1131] Process test migration from v7 legacy runtime to code generation - 2 #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase plz |
Abhitocode
force-pushed
the
incubator-kie-issues-1131-2
branch
3 times, most recently
from
May 24, 2024 04:16
42e59f2
to
6f37959
Compare
elguardian
approved these changes
May 24, 2024
martinweiler
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order of import statement needs to be fixed, otherwise LGTM @Abhitocode
Abhitocode
force-pushed
the
incubator-kie-issues-1131-2
branch
from
May 27, 2024 03:02
b8186e5
to
6f37959
Compare
This was referenced May 28, 2024
Abhitocode
force-pushed
the
incubator-kie-issues-1131-2
branch
from
June 5, 2024 03:01
4aa8902
to
6f37959
Compare
remember -Dvalidate-formatting in local when you execute
|
to avoid merge...
use rebase instead of just pulling. |
Abhitocode
force-pushed
the
incubator-kie-issues-1131-2
branch
from
June 6, 2024 18:34
7fe74fd
to
6f37959
Compare
…time to code generation
Abhitocode
force-pushed
the
incubator-kie-issues-1131-2
branch
from
June 7, 2024 03:15
6f37959
to
320fdfd
Compare
Abhitocode
added a commit
to Abhitocode/incubator-kie-kogito-runtimes
that referenced
this pull request
Jun 7, 2024
…gacy runtime to code generation (apache#3520)" This reverts commit 3432985.
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Jun 10, 2024
…time to code generation (apache#3520) good work @Abhitocode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to previous changes associated with PR's #3516
& #3519
Migrated some BPMN processes which are being compiled using legacy v7 to code generation approach, using new branch incubator-kie-issues-1131-2
The tests can be identified by referring to Activitytest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java
Issue: apache/incubator-kie-issues#1131