Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1131] Process test migration from v7 legacy runtime to code generation - 2 #3520

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Abhitocode
Copy link
Contributor

In addition to previous changes associated with PR's #3516
& #3519
Migrated some BPMN processes which are being compiled using legacy v7 to code generation approach, using new branch incubator-kie-issues-1131-2

The tests can be identified by referring to Activitytest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java

Issue: apache/incubator-kie-issues#1131

@elguardian
Copy link
Contributor

rebase plz

@elguardian elguardian self-requested a review May 23, 2024 08:46
@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-2 branch 3 times, most recently from 42e59f2 to 6f37959 Compare May 24, 2024 04:16
@elguardian elguardian marked this pull request as ready for review May 24, 2024 07:21
Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of import statement needs to be fixed, otherwise LGTM @Abhitocode

@elguardian
Copy link
Contributor

remember -Dvalidate-formatting in local when you execute

mvn clean install -DskipTests -Dvalidate-formatting

@elguardian
Copy link
Contributor

to avoid merge...

git pull --rebase upstream main

use rebase instead of just pulling.

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-2 branch from 7fe74fd to 6f37959 Compare June 6, 2024 18:34
@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-2 branch from 6f37959 to 320fdfd Compare June 7, 2024 03:15
@elguardian elguardian merged commit 3432985 into apache:main Jun 7, 2024
6 checks passed
Abhitocode added a commit to Abhitocode/incubator-kie-kogito-runtimes that referenced this pull request Jun 7, 2024
…gacy runtime to code generation (apache#3520)"

This reverts commit 3432985.
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants