IGNITE-22150 .NET: Add PartitionManager API #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
changed the title
isapego
approved these changes
Jul 9, 2024
Comment on lines
22
to
28
| /// <summary> | ||
| /// Table partition. | ||
| /// </summary> | ||
| [SuppressMessage("Design", "CA1040:Avoid empty interfaces", Justification = "Reviewed.")] | ||
| public interface IPartition | ||
| { | ||
| } |
There was a problem hiding this comment.
Hmm, should not we at least support comparison operations?
There was a problem hiding this comment.
Do you mean relative comparison, or just equality?
Value-based equality is supported by the HashPartition implementation (two instances with the same id are considered equal).
There was a problem hiding this comment.
After some thinking I agree. Added IEquatable to the interface to make things clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITable.PartitionManagerAPI (GetPrimaryReplicas,GetPartition)PartitionAssignmentTimestamp