IGNITE-22218 Remove TableRaftService in favor of using RaftGroupService from Replica instances #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
…on waiting of restart
…maryReplicaChoiceTest` and `ItBuildIndexTest`
…sContain` is rewritten
# Conflicts: # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
# Conflicts: # modules/table/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
…gAssignmentEvent` branch
…balance` (don't know actually why)
# Conflicts: # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteInMemoryNodeRestartTest.java # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
# Conflicts: # modules/index/src/integrationTest/java/org/apache/ignite/internal/index/ItBuildIndexTest.java # modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteInMemoryNodeRestartTest.java # modules/table/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
…Started` calls and `replica(...)` calls are asynchronous now.
…re events (eg inhibitors are enabled) => no primary => return false
…DestroyPartitionAndUpdateClients` with chaining of peer set update future and stop&destroy partition future instead of allOf.
# Conflicts: # modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java # modules/table/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java # modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java
# Conflicts: # modules/index/src/integrationTest/java/org/apache/ignite/internal/index/ItBuildIndexTest.java
sanpwc
reviewed
Jul 22, 2024
| @@ -81,6 +81,7 @@ dependencies { | |||
| integrationTestImplementation testFixtures(project(':ignite-table')) | |||
| integrationTestImplementation testFixtures(project(':ignite-storage-api')) | |||
| integrationTestImplementation testFixtures(project(':ignite-catalog')) | |||
| integrationTestImplementation testFixtures(project(':ignite-replicator')) | |||
There was a problem hiding this comment.
Why do we need this dependency?
There was a problem hiding this comment.
The new ReplicaTestUtils is placed there
| ScheduledExecutorService rebalanceScheduler | ||
| ) { | ||
| ScheduledExecutorService rebalanceScheduler, | ||
| ClockService clockService, PlacementDriver placementDriver) { |
There was a problem hiding this comment.
One at a row, please. Please also move ) { to a separate row.
| @@ -190,6 +205,9 @@ public PartitionReplicaLifecycleManager( | |||
| this.lowWatermark = lowWatermark; | |||
| this.ioExecutor = ioExecutor; | |||
| this.rebalanceScheduler = rebalanceScheduler; | |||
| this.clockService = clockService; | |||
| // should it be ExecutorInclinedPlacementDriver as in TableManager? | |||
There was a problem hiding this comment.
Yes it should. And don't forget to remove the comment.
There was a problem hiding this comment.
Couldn't pass ExecutorInclinedPlacementDriver there because it came from :ignite-table, but there a circular dependency arises:
:ignite-partition-replicator:compileJava
\--- :ignite-table:compileJava
\--- :ignite-partition-replicator:compileJava (*)
Is it crucial?
| return assignments.stream().anyMatch(isLocalNodeAssignment); | ||
| } | ||
|
|
||
| private CompletableFuture<Boolean> isLocalNodeLeaseholder(ReplicationGroupId replicationGroupId) { |
There was a problem hiding this comment.
I'd rather use isLocalNodeIsPrimary instead of "...Leaseholder".
| return assignments.stream().anyMatch(isLocalNodeAssignment); | ||
| } | ||
|
|
||
| private CompletableFuture<Boolean> isLocalNodeLeaseholder(ReplicationGroupId replicationGroupId) { |
There was a problem hiding this comment.
Could you please add javadoc explaning contract of the method. Especially it's important to clarify how do we evaluate base timestamp for leaseholder detection.
There was a problem hiding this comment.
Java doc is added, the method is fixed due to the lifecycle manager's version some how became is out of date a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-22218 | Remove
TableRaftServicein favor of usingRaftGroupServicefromReplicainstancesThe goal
The goal of the PR is to remove
TableRaftServiceand it's usages.The reason
TableRaftServiceis a leakage of RAFT-specific code onto other layers that should be prohibited.The solution
All occurrences should be replaced with:
Class
TableRaftServiceshould be removed completely.Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes