Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support custom refresh intervals for each group of metrics #2252

Closed
wants to merge 9 commits into from

Conversation

zuobiao-zhou
Copy link
Contributor

What's changed?

close #2188

Support custom refresh intervals for each group of metrics. The specific implementation is as follows:

Within a monitor, metrics with different refresh intervals are divided into different jobs. If a group's metrics do not have a custom refresh interval set, the default refresh interval specified during the monitor's creation will be used.

Implementation result:
image
image
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@github-actions github-actions bot added doc Improvements or additions to documentation backend labels Jul 9, 2024
@zqr10159 zqr10159 requested a review from tomsun28 July 9, 2024 07:41
@tomsun28 tomsun28 added good first pull request Good for newcomers enhancement New feature or request feature labels Jul 9, 2024
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jul 9, 2024
@tomsun28
Copy link
Contributor

tomsun28 commented Jul 9, 2024

hi, thanks for contributions. 👍

The one monitor mapping one collect job -> many collect jobs is a big change, we need time to think and design carefully.
This will cause some collection logics on the collector side to fail, such as supporting sequential collection and concurrent collection, using the collection response as a parameter to enter the next collection metrics, etc. System upgrade is also a big hassle.

Previously, I thought the modification direction was in the collector scheduling part, splitting the scheduling time of multiple metrics tasks in a job corresponding to a monitoring.

These two directions need to be carefully considered.

@zuobiao-zhou
Copy link
Contributor Author

hi, thanks for contributions. 👍

The one monitor mapping one collect job -> many collect jobs is a big change, we need time to think and design carefully. This will cause some collection logics on the collector side to fail, such as supporting sequential collection and concurrent collection, using the collection response as a parameter to enter the next collection metrics, etc. System upgrade is also a big hassle.

Previously, I thought the modification direction was in the collector scheduling part, splitting the scheduling time of multiple metrics tasks in a job corresponding to a monitoring.

These two directions need to be carefully considered.

That makes sense, I'll try to implement the second approach.

@tomsun28
Copy link
Contributor

hi, i draw a job task relation for refer. The main difficulty here is the scheduling of multiple metrics collection under one job. At present, I have not thought of a good way to support custom scheduling time.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend doc Improvements or additions to documentation enhancement New feature or request feature good first pull request Good for newcomers
Projects
Development

Successfully merging this pull request may close these issues.

[Task] Customizable Refresh Intervals for Monitoring Metrics
2 participants