[Java] Format integration tests code #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chaokunyang
commented
Dec 26, 2023
chaokunyang
commented
- Format integration tests code
- Upgrade spotless plugin to support JDK 17&21
- Format java code using upgraded spotless plugin
chaokunyang
force-pushed
the
format_integration_tests_code
branch
from
9cb708c
to
086dc0c
Compare
theweipeng
approved these changes
Dec 27, 2023
tisonkun
reviewed
Dec 27, 2023
| @@ -246,7 +246,8 @@ | |||
| <configuration> | |||
| <java> | |||
| <googleJavaFormat> | |||
| <version>1.7</version> | |||
| <!-- 1.19.1 support JDK21 --> | |||
| <version>1.19.1</version> | |||
| <style>GOOGLE</style> | |||
There was a problem hiding this comment.
I'll suggest we use the plantir style for longer line length and better breaking lines strategy.
There was a problem hiding this comment.
You can check this build https://github.com/apache/curator/blob/111f3a6bdcd562db0493e52243e5cec933cc36ef/pom.xml#L933-L954.
There was a problem hiding this comment.
Thanks, I will do this in another PR
There was a problem hiding this comment.
plantir style seems doesn't support 2 spaces: palantir/palantir-java-format#951. I suggest continuing to use google code style
|
Spotless plugin version upgrade breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.