-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Format integration tests code #1263
[Java] Format integration tests code #1263
Conversation
chaokunyang
commented
Dec 26, 2023
- Format integration tests code
- Upgrade spotless plugin to support JDK 17&21
- Format java code using upgraded spotless plugin
9cb708c
to
086dc0c
Compare
@@ -246,7 +246,8 @@ | |||
<configuration> | |||
<java> | |||
<googleJavaFormat> | |||
<version>1.7</version> | |||
<!-- 1.19.1 support JDK21 --> | |||
<version>1.19.1</version> | |||
<style>GOOGLE</style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll suggest we use the plantir style for longer line length and better breaking lines strategy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check this build https://github.com/apache/curator/blob/111f3a6bdcd562db0493e52243e5cec933cc36ef/pom.xml#L933-L954.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will do this in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plantir style seems doesn't support 2 spaces: palantir/palantir-java-format#951. I suggest continuing to use google code style
Spotless plugin version upgrade breaks |