[FLINK-36809][table] Support ignoreIfExists param for createTable #25704
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalthr
reviewed
Nov 27, 2024
| * in the catalog. | ||
| * | ||
| * <p>If the table should not be permanently stored in a catalog, use {@link | ||
| * #createTemporaryTable(String, TableDescriptor)} instead. |
There was a problem hiding this comment.
we should also support the boolean flag for createTemporaryTable and link it here
| * @param ignoreIfExists If a table exists under the given path and this flag is set, no | ||
| * operation is executed. An exception is thrown otherwise. | ||
| */ | ||
| void createTable(String path, TableDescriptor descriptor, boolean ignoreIfExists); |
There was a problem hiding this comment.
can you check whether Python already supports createTable with TableDescriptors. if yes, we should also add the method there. check flink/flink-python/pyflink/table/table_environment.py
| .option("a", "Test") | ||
| .build(), | ||
| false)) | ||
| .isInstanceOf(ValidationException.class); |
There was a problem hiding this comment.
ideally, we should also check the error message. at least parts of it. hasMessageContaining could do the job?
Comment on lines
+110
to
+128
| final Schema schema = Schema.newBuilder().column("f0", DataTypes.INT()).build(); | ||
| tEnv.createTable( | ||
| "T", | ||
| TableDescriptor.forConnector("fake").schema(schema).option("a", "Test").build(), | ||
| true); | ||
|
|
||
| final ObjectPath objectPath = new ObjectPath(database, "T"); | ||
| assertThat( | ||
| tEnv.getCatalog(catalog) | ||
| .orElseThrow(AssertionError::new) | ||
| .tableExists(objectPath)) | ||
| .isTrue(); | ||
|
|
||
| final CatalogBaseTable catalogTable = | ||
| tEnv.getCatalog(catalog).orElseThrow(AssertionError::new).getTable(objectPath); | ||
| assertThat(catalogTable).isInstanceOf(CatalogTable.class); | ||
| assertThat(catalogTable.getUnresolvedSchema()).isEqualTo(schema); | ||
| assertThat(catalogTable.getOptions()) | ||
| .contains(entry("connector", "fake"), entry("a", "Test")); |
There was a problem hiding this comment.
this code is duplicated with the test above. create a private helper method e.g. assertTableFromDescriptor(String name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support ignoreIfExists for createTable. Works exactly the same way for other resources, like createFunction. Similar to SQL's
IF NOT EXISTS.Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation