-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] [docs]Fix miss semicolon on SELECT & WHERE clause example sql #25673
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
IIRC semicolon is just a statement terminator and it always should be used to inform parser that the statement is finished, so it is ok to not specify it in such doc having this in mind.
Even more there is no concrete example with concrete environment.
For instance if we try to use these examples with Flink SQL Client then yes we need to use semicolon, however if we try to use this with Table SQL then there is no need for that
I know what you mean. But I suggest it's better to unify it in the docs, rather than having some IIRC and others not @snuyanzin |
then I don't think the unification is limited only to you can have a look at |
You might be right in a way. So, who will ask for the mailing list? @snuyanzin |
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Fix miss semicolon on SELECT & WHERE clause example sql.
Brief change log
Add semicolon for miss semicolon example sql.
Verifying this change
Since the changes affect the doc examples and there are no tests. I copied the snippets and verified (compiled) them locally.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation