Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36745][docs] Make FixedSizeSplitFetcherManager and FixedFetcherSizeSourceReader examples match Flink 2.0-preview API #25667

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kaygorodov
Copy link

@kaygorodov kaygorodov commented Nov 18, 2024

What is the purpose of the change

Examples on documentation page Data Sources have been using the APIs that do not exist anymore in Flink 2.0-preview.

Brief change log

  • switch FixedSizeSplitFetcherManager, FixedFetcherSizeSourceReader to use proper constructors of their super classes
  • switch from getInteger to get method of the Configuration class

Verifying this change

  • Since the changes affect the doc examples and there are no tests. I copied the snippets and verified (compiled) them locally.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 18, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@kaygorodov kaygorodov changed the title [FLINK-36745][docs] Make FixedSizeSplitFetcherManager and FixedFetcherSizeSourceReader examples match Flink 2.0 API [FLINK-36745][docs] Make FixedSizeSplitFetcherManager and FixedFetcherSizeSourceReader examples match Flink 1.20 API Nov 18, 2024
@kaygorodov kaygorodov changed the title [FLINK-36745][docs] Make FixedSizeSplitFetcherManager and FixedFetcherSizeSourceReader examples match Flink 1.20 API [FLINK-36745][docs] Make FixedSizeSplitFetcherManager and FixedFetcherSizeSourceReader examples match Flink 2.0-preview API Nov 18, 2024
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davidradl
Copy link

Reviewed by Chi on 21/11/24 Need a committer to review

1 similar comment
@davidradl
Copy link

Reviewed by Chi on 21/11/24 Need a committer to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants