Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33231] [source] Properly evict offsetsToCommit cache on checkpoint complete if no offsets exist #58

Merged
merged 1 commit into from
Oct 11, 2023

Commits on Oct 10, 2023

  1. [FLINK-33231] [source] Properly evict offsetsToCommit cache on checkp…

    …oint complete if no offsets exist
    
    Prior to this fix, if the offsets to commit for a given checkpoint is empty,
    which can be the case if no starting offsets were retrieved from Kafka yet,
    then on checkpoint completion the cache is not properly evicted up to the
    given checkpoint.
    
    This change fixes this such that in notifyOnCheckpointComplete, we shortcut
    the method execution to not need to try to commit the offsets since its
    empty anyways, and always remember to evict the cache up to the completed
    checkpoint.
    tzulitai committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1b4c978 View commit details
    Browse the repository at this point in the history