[FLINK-33219][connector/kafka] Add new archunit violation messages introduced by FLINK-31804 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troduced by FLINK-31804 The reason we add new violation messages instead of update existing ones is that the patch of FLINK-31804 is only applied after Flink 1.18. We need to make sure the CI could run successfully for Flink versions before and after that. If Kafka connector decides to drop support for versions before 1.18 in the future, please re-freeze the violations then.
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
…build to verify the change works
MartijnVisser
approved these changes
Oct 9, 2023
.github/workflows/push_pr.yml
Outdated
| @@ -23,6 +23,10 @@ concurrency: | |||
| cancel-in-progress: true | |||
| jobs: | |||
| compile_and_test: | |||
| strategy: | |||
| matrix: | |||
| flink: [ 1.17-SNAPSHOT, 1.18-SNAPSHOT ] | |||
There was a problem hiding this comment.
Suggested change
| flink: [ 1.17-SNAPSHOT, 1.18-SNAPSHOT ] | |
| flink: [ 1.17.1, 1.18-SNAPSHOT ] |
MartijnVisser
force-pushed
the
FLINK-33219
branch
from
4b73b4a
to
67046d8
Compare
MartijnVisser
force-pushed
the
FLINK-33219
branch
from
9a8a516
to
d83564c
Compare
|
Awesome work, congrats on your first merged pull request! |
MartijnVisser
pushed a commit
to MartijnVisser/flink-connector-kafka
that referenced
this pull request
Oct 25, 2023
…troduced by FLINK-31804. This closes apache#56 * [FLINK-33219][connector/kafka] Add new archunit violation messages introduced by FLINK-31804 The reason we add new violation messages instead of update existing ones is that the patch of FLINK-31804 is only applied after Flink 1.18. We need to make sure the CI could run successfully for Flink versions before and after that. If Kafka connector decides to drop support for versions before 1.18 in the future, please re-freeze the violations then. Co-authored-by: Martijn Visser <[email protected]> (cherry picked from commit b09928d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason we add new violation messages instead of update existing ones is that the patch of FLINK-31804 is only applied after Flink 1.18. We need to make sure the CI could run successfully for Flink versions before and after that.
If Kafka connector decides to drop support for versions before 1.18 in the future, please re-freeze the violations then.