[FLINK-36780] Kafka source disables partition discovery unexpectedly #136
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
liuml07
commented
Nov 23, 2024
| @@ -217,6 +217,29 @@ public void testSettingInvalidCustomDeserializers( | |||
| .hasMessageContaining(expectedError); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testDefaultPartitionDiscovery() { | |||
There was a problem hiding this comment.
This test fails without the fix, and passes now with the fix.
liuml07
commented
Nov 23, 2024
| } | ||
|
|
||
| @Test | ||
| public void testPeriodPartitionDiscovery() { |
There was a problem hiding this comment.
This newly added test is to avoid regressions for bounded source.
liuml07
changed the title
pnowojski
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Kafka source enables partition discovery. This is set by partition.discovery.interval.ms, aka KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS. The default value is 5 minutes, which is equal to the default value of metadata.max.age.ms in Kafka.
However, it's disabled by default unexpectedly in the source builder (code). The intention I believe was to only disable for bounded source.
We need a fix that is able to keep the default partition discovery. This could cause data loss after Kafka retention if the new partitions are not consumed silently.