-
Notifications
You must be signed in to change notification settings - Fork 127
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-28758] Fix stop-with-savepoint for FlinkKafkaConsumer
- Loading branch information
Showing
4 changed files
with
133 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
...a/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerITCase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.streaming.connectors.kafka; | ||
|
|
||
| import org.apache.flink.api.common.ExecutionConfig; | ||
| import org.apache.flink.api.common.functions.MapFunction; | ||
| import org.apache.flink.api.common.serialization.TypeInformationSerializationSchema; | ||
| import org.apache.flink.api.common.typeinfo.BasicTypeInfo; | ||
| import org.apache.flink.configuration.CheckpointingOptions; | ||
| import org.apache.flink.configuration.Configuration; | ||
| import org.apache.flink.connector.kafka.testutils.KafkaSourceTestEnv; | ||
| import org.apache.flink.core.execution.JobClient; | ||
| import org.apache.flink.core.execution.SavepointFormatType; | ||
| import org.apache.flink.streaming.api.datastream.DataStreamSource; | ||
| import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; | ||
| import org.apache.flink.streaming.api.functions.sink.DiscardingSink; | ||
| import org.apache.kafka.clients.consumer.ConsumerConfig; | ||
| import org.junit.jupiter.api.*; | ||
| import org.junit.jupiter.api.TestInstance.Lifecycle; | ||
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
||
| import java.nio.file.Path; | ||
| import java.util.Arrays; | ||
| import java.util.Properties; | ||
| import java.util.concurrent.CountDownLatch; | ||
|
|
||
| /** ITCase tests class for {@link FlinkKafkaConsumer}. */ | ||
| public class FlinkKafkaConsumerITCase { | ||
| private static final String TOPIC1 = "topic1"; | ||
| private static final String TOPIC2 = "topic2"; | ||
|
|
||
| @Nested | ||
| @TestInstance(Lifecycle.PER_CLASS) | ||
| class KafkaSpecificTests { | ||
| @BeforeAll | ||
| public void setup() throws Throwable { | ||
| KafkaSourceTestEnv.setup(); | ||
| KafkaSourceTestEnv.setupTopic( | ||
| TOPIC1, true, true, KafkaSourceTestEnv::getRecordsForTopicWithoutTimestamp); | ||
| KafkaSourceTestEnv.setupTopic( | ||
| TOPIC2, true, true, KafkaSourceTestEnv::getRecordsForTopicWithoutTimestamp); | ||
| } | ||
|
|
||
| @AfterAll | ||
| public void tearDown() throws Exception { | ||
| KafkaSourceTestEnv.tearDown(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testStopWithSavepoint(@TempDir Path savepointsDir) throws Exception { | ||
| Configuration config = | ||
| new Configuration() | ||
| .set( | ||
| CheckpointingOptions.SAVEPOINT_DIRECTORY, | ||
| savepointsDir.toUri().toString()); | ||
| StreamExecutionEnvironment env = | ||
| StreamExecutionEnvironment.getExecutionEnvironment(config); | ||
| env.setParallelism(1); | ||
|
|
||
| Properties properties = new Properties(); | ||
| properties.setProperty( | ||
| ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, | ||
| KafkaSourceTestEnv.brokerConnectionStrings); | ||
| properties.setProperty(ConsumerConfig.GROUP_ID_CONFIG, "testStopWithSavepoint"); | ||
| properties.setProperty(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest"); | ||
|
|
||
| FlinkKafkaConsumer<Integer> kafkaConsumer = | ||
| new FlinkKafkaConsumer<>( | ||
| Arrays.asList(TOPIC1, TOPIC2), | ||
| new TypeInformationSerializationSchema<>( | ||
| BasicTypeInfo.INT_TYPE_INFO, new ExecutionConfig()), | ||
| properties); | ||
| DataStreamSource<Integer> stream = env.addSource(kafkaConsumer); | ||
|
|
||
| ProgressLatchingIdentityFunction.resetBeforeUse(); | ||
| stream.map(new ProgressLatchingIdentityFunction()).addSink(new DiscardingSink<>()); | ||
|
|
||
| JobClient jobClient = env.executeAsync(); | ||
|
|
||
| ProgressLatchingIdentityFunction.getProgressLatch().await(); | ||
|
|
||
| // Check that stopWithSavepoint completes successfully | ||
| jobClient.stopWithSavepoint(false, null, SavepointFormatType.CANONICAL).get(); | ||
| // TODO: ideally we should test recovery, that there were no data losses etc, but this | ||
| // is already a deprecated class, so I'm not adding new tests for that now. | ||
| } | ||
| } | ||
|
|
||
| private static class ProgressLatchingIdentityFunction implements MapFunction<Integer, Integer> { | ||
|
|
||
| static CountDownLatch progressLatch; | ||
|
|
||
| static void resetBeforeUse() { | ||
| progressLatch = new CountDownLatch(1); | ||
| } | ||
|
|
||
| public static CountDownLatch getProgressLatch() { | ||
| return progressLatch; | ||
| } | ||
|
|
||
| @Override | ||
| public Integer map(Integer integer) throws Exception { | ||
| progressLatch.countDown(); | ||
| return integer; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters