Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Update NOTICE files to reflect the packaged dependencies #180

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

hlteoh37
Copy link
Contributor

@hlteoh37 hlteoh37 commented Nov 6, 2024

Purpose of the change

Fix NOTICE files to reflect the dependencies packaged into the uber jar.

Verifying this change

Validated using helpful script provided by @dannycranmer

mvn clean install | grep Including | grep -v org.apache.flink | sed -E 's/\S+\s+\S+\s+(\S+).*/\1/' | sed 's/:jar//' | sed 's/.*Including \(.*\) in the shaded jar\./\1/' | sort > /tmp/from.build
cat src/main/resources/META-INF/NOTICE | grep "^\- " | sed 's/- //' | sort > /tmp/from.notice
diff /tmp/from.build /tmp/from.notice

Significant changes

(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

@hlteoh37 hlteoh37 merged commit e0e1b30 into apache:main Nov 6, 2024
9 checks passed
@hlteoh37 hlteoh37 deleted the hotfix-notice branch November 6, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants