Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option deploymentIosTarget (ios) #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

didix21
Copy link

@didix21 didix21 commented Jul 29, 2019

If is set ios platform and deploymentIosTarget is going to add the following field <preference name="deployment-target" value="${deploymentIosTarget}" />on the config.xml.

Use case

The main porpuse of this new feature is for those plugins that have been developed in Swift and any of their dependencies needs a minimum iOS version configured in the config.xml file.

Checklist

  • I've run the tests to see all new and existing tests pass
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • I've updated the documentation if necessary

If is set ios platform and deploymentIosTarget is going to add the following field `<preference name="deployment-target" value="${deploymentIosTarget}" />`on the `config.xml`.
@janpio
Copy link
Member

janpio commented Jul 30, 2019

Thanks for this PR.

Can you elaborate on the use case a bit maybe? What kind of plugins need this? Example?

@didix21
Copy link
Author

didix21 commented Jul 31, 2019

Thanks for this PR.

Can you elaborate on the use case a bit maybe? What kind of plugins need this? Example?

I can't share a concrete example but I'm developing a plugin for my company and this feature is required. I think it can be useful for future plugins developed with swift and need a minimum version of iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants