Simplify UriParser #558
Merged
Simplify UriParser #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
force-pushed
the
simplify-UriParser-with-rollback
branch
from
6d529ba
to
93e50cc
Compare
raboof
force-pushed
the
simplify-UriParser-with-rollback
branch
from
93e50cc
to
0619860
Compare
Closed
|
I'd be OK to merge. Anyone else? |
|
I also think it's OK to merge. |
|
@japplis I'm more concerned about the semantics than implementation details at this point. |
The reverts apache#396 and related changes and implements the same in a simpler way by replacing the encoded characters already in `fixSeparators`. This approach has a slightly higher risk at breaking existing behaviour, but a lower risk of remaining problems in this part of the codebase. All testcases still succeed. This PR is intended to replace apache#543 and apache#555. It includes the testcases from apache#543, adapted to the behaviour before apache#396. This reverts commit cb45c94. This reverts commit 5399c76. Co-Authored-By: Anthony Goubard <[email protected]>
raboof
force-pushed
the
simplify-UriParser-with-rollback
branch
from
0619860
to
38a8976
Compare
|
@raboof |
garydgregory
added a commit
that referenced
this pull request
Jul 27, 2024
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverts #396 and related
changes and implements the same in a simpler way by replacing the
encoded characters already in
fixSeparators.This approach has a slightly higher risk at breaking existing behaviour,
but a lower risk of remaining problems in this part of the codebase. All
testcases still succeed.
This PR is intended to replace #543 and #555. It includes the testcases
from #543, adapted to the behaviour before #396.
This reverts commit cb45c94.
This reverts commit 5399c76.
This seems only slightly (<8%) slower than #547 , which might be acceptable as it's not obvious this is a bottleneck:
Should probably add some more tests exercising the problems that remain after the fixes from #543