Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid jpeg parse fail due to jfxx and exif #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hyunuck
Copy link

@hyunuck hyunuck commented Mar 28, 2018

  • add jfxx signature when parsing jpeg
  • Avoid jpeg parse fail due to exif

exif = getExifMetadata(byteSource, params);
} catch (Exception e) {
// exif parse failed.
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still fail here. Other parsers such as the TiffImageParser fail, so JpegImageParser not throwing an exception would be wrong.

Also, not even logging the exception can cause problems to users of the API that would have to debug the code to understand why they were not seeing the EXIF metadata, just to find an exception that was not propagated.

The rest of the code looks good. Would you be able to provide at least one unit tests for your code @hyunuck, please?

Thanks
Bruno

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping AND there are no tests.

@kinow kinow added the someday label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants