Fix latency reported by ideal consistency level monitoring #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idealCLWriteLatency metric reported the worst response time instead of the time when ideal CL is satisfied. Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-19651
aweisberg
requested changes
Jul 16, 2024
test/unit/org/apache/cassandra/service/WriteResponseHandlerTest.java
Outdated
Show resolved
Hide resolved
| @@ -280,6 +289,8 @@ public void onFailure(InetAddressAndPort from, RequestFailureReason failureReaso | |||
|
|
|||
| failureReasonByEndpoint.put(from, failureReason); | |||
|
|
|||
| logFailureOrTimeoutToIdealCLDelegate(); | |||
There was a problem hiding this comment.
Ouch looks like the failure path didn't decrement at all before?
I guess the only reason it gave some signal was because we would call expired explicitly if gossip thought the endpoint was down so it would be a non-zero metric.
There was a problem hiding this comment.
yes, I think so, for prolonged node loss cases detected by gossip we have another path via expired() method.
Patch by Dmitry Konstantinov; reviewed by Ariel Weisberg for CASSANDRA-19651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idealCLWriteLatency metric reported the worst response time instead of the time when ideal CL is satisfied.
Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-19651