Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support batch butex wake with the same tag #2778

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

yanglimingcn
Copy link
Contributor

What problem does this PR solve?

Issue Number: #2777

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 12, 2024

这个修改对性能有影响吗?

@yanglimingcn
Copy link
Contributor Author

这个修改对性能有影响吗?

对性能没有影响,默认butex的唤醒就是每个waiter都会signal的,只有使用CountdownEvent的时候,主动设置了void signal(int sig = 1, bool flush = false); flush=true才会有相关的影响。

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 12, 2024

持续集成失败和改动有关吗?

@yanglimingcn
Copy link
Contributor Author

持续集成失败和改动有关吗?

看上去不相关,主要是streaming那个case报错,我本地跑这个case没问题。

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 14, 2024

LGTM

Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit f6f76dd into apache:master Oct 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants