Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on ENETUNREACH or EHOSTUNREACH #2295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

允许在发生ENETUNREACH 或者EHOSTUNREACH时重试。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Jul 10, 2023

这个改了框架默认行为,感觉不太合适,用户有需求的话自己定义RetryPolicy是不是就可以了?

@chenBright
Copy link
Contributor Author

也可以。
想了解一下,基于什么考虑,框架默认行为不重试ENETUNREACH、EHOSTUNREACH,而是让RPC直接失败呢?

@wwbmmm
Copy link
Contributor

wwbmmm commented Jul 10, 2023

不太清楚最初的考虑,@jamesge 知道吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants