GH-44817: [CI] Comment new repo url on issues of moved components #44818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
awaiting merge
kou
reviewed
Nov 24, 2024
| steps: | ||
| - uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 | ||
| with: | ||
| script: | | ||
| let repo_moved_msg = component => `The ${component} implementation has moved to https://github.com/apache/arrow-${component}.` + | ||
| "\nPlease close this one and open your issue there."; |
There was a problem hiding this comment.
It seems that \n didn't work: assignUser#23 (comment)
| steps: | ||
| - uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 | ||
| with: | ||
| script: | | ||
| let repo_moved_msg = component => `The ${component} implementation has moved to https://github.com/apache/arrow-${component}.` + |
There was a problem hiding this comment.
Suggested change
| let repo_moved_msg = component => `The ${component} implementation has moved to https://github.com/apache/arrow-${component}.` + | |
| let repo_moved_msg = component => `The ${component} implementation has moved to https://github.com/apache/arrow-${component.toLowerCase}.` + |
| .map(component => component.trim()); | ||
| let moved_components = components.filter(comp => ["Go"].includes(comp)); | ||
|
|
||
| if (moved_components.length != 0){ |
There was a problem hiding this comment.
Suggested change
| if (moved_components.length != 0){ | |
| if (moved_components.length != 0) { |
| .map(component => component.trim()) | ||
| .map(component => "Component: " + component); | ||
| .map(component => component.trim()); | ||
| let moved_components = components.filter(comp => ["Go"].includes(comp)); |
There was a problem hiding this comment.
How about using find not filter because this only uses the first found component?
| "issue_number": context.payload.issue.number, | ||
| "body": repo_moved_msg(moved_components[0]), | ||
| }); | ||
| console.log("blub") |
There was a problem hiding this comment.
Suggested change
| console.log("blub") |
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Point people to the correct repo.
What changes are included in this PR?
Are these changes tested?
I tested it on my fork: assignUser#23
Are there any user-facing changes?
No