Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-14784: [Dev] Add possibility to autoassign on GitHub issue comment #14785

Merged
merged 2 commits into from
Dec 2, 2022
Merged

GH-14784: [Dev] Add possibility to autoassign on GitHub issue comment #14785

merged 2 commits into from
Dec 2, 2022

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 30, 2022 •
edited
Loading

This PR will allow a user to type take in an issue comment and the issue will automatically be assigned to them.

@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited by jorisvandenbossche
Loading

@raulcd
Copy link
Member Author

raulcd commented Nov 30, 2022

I have tested this workflow on my fork: raulcd#60 (comment)

jorisvandenbossche
jorisvandenbossche approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raulcd
Copy link
Member Author

raulcd commented Dec 1, 2022

Tested the latest change again on my fork on the same issue as above: raulcd#60 (comment)

assignUser
assignUser approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

kou
kou approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 90d1dd1 into apache:master Dec 2, 2022
@kou kou mentioned this pull request Dec 2, 2022
Closed
@ursabot
Copy link

ursabot commented Dec 2, 2022

Benchmark runs are scheduled for baseline = f51ea4d and contender = 90d1dd1. 90d1dd1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.1% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.3% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 90d1dd18 ec2-t3-xlarge-us-east-2
[Failed] 90d1dd18 test-mac-arm
[Failed] 90d1dd18 ursa-i9-9960x
[Finished] 90d1dd18 ursa-thinkcentre-m75q
[Finished] f51ea4de ec2-t3-xlarge-us-east-2
[Failed] f51ea4de test-mac-arm
[Failed] f51ea4de ursa-i9-9960x
[Finished] f51ea4de ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@assignUser assignUser mentioned this pull request Dec 2, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@assignUser assignUser assignUser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raulcd @ursabot @kou @jorisvandenbossche @assignUser