-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the endless sensor reschedule #45224
Fixed the endless sensor reschedule #45224
Conversation
22581c1
to
4080eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Sounds meaningful. Special thanks for the extensions and intensive test added as well.
I'd assume it also makes sense to port this back to Airflow 2.10-line? Does anything speaks against this?
Backport failed to create: v2-10-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 7f2b8ef v2-10-test This should apply the commit to the v2-10-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
(cherry picked from commit 7f2b8ef) Co-authored-by: morooshka <[email protected]>
(cherry picked from commit 7f2b8ef) Co-authored-by: morooshka <[email protected]>
Fixed the endless sensor reschedule
Rescheduling mode. In case of unhandled exception occurred during the sensor's first try run the rescheduling attempt is not saved into DB because of the full transaction rollback. the "first try" here can be also the first one after clearing the task. In that case the start moment for calculating the task running duration should be taken as:
closes: #45050