Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessageDeduplicationId support to AWS SqsPublishOperator #45051

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Prab-27
Copy link
Contributor

@Prab-27 Prab-27 commented Dec 18, 2024

Closes : #44876

Currently, the SqsPublishOperator in Airflow does not support the MessageDeduplicationId parameter for deduplication of messages sent to AWS SQS FIFO queues. Users are forced to rely solely on ContentBasedDeduplication, which may not be suitable for all scenarios.

This PR aims to add support for MessageDeduplicationId and test for deduplication to provide more flexibility and control over message deduplication.

(https://boto3.amazonaws.com/v1/documentation/api/1.35.6/reference/services/sqs/client/send_message.html))


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Dec 18, 2024
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs also a test for the success scenario.
You can add the needed changes to test_execute_success or write a separated test if needed

@Prab-27
Copy link
Contributor Author

Prab-27 commented Dec 22, 2024

Needs also a test for the success scenario. You can add the needed changes to test_execute_success or write a separated test if needed

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MessageDeduplicationId support to SqsPublishOperator
3 participants