Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the implementation of memoizeSupplier. #1101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions cyclops/src/main/java/cyclops/function/Memoize.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,28 +23,25 @@
import lombok.val;

public class Memoize {
private final static Object UNSET = new Object();

/**
* Convert a Supplier into one that caches it's result
*
* @param s Supplier to memoise
* @return Memoised Supplier
*/
public static <T> Function0<T> memoizeSupplier(final Supplier<T> s) {
AtomicReference value = new AtomicReference<>(
UNSET);
return ()->{
Object val = value.get();
if (val == UNSET) {
synchronized (value){
if(value.get()==UNSET) {
val = s.get();
value.set(val);
final AtomicReference<T> atomic = new AtomicReference<>(null);
return () -> {
if (atomic.get() == null) {
synchronized (atomic) {
if (atomic.get() == null) {
T val = s.get();
atomic.set(val);
}
}
}
}

return (T)val;
return atomic.get();
};

}
Expand Down