New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1427 failure emails missing collection name #348

Merged

craigrose merged 5 commits into master from 1427-failure-emails-missing-collection-name

Nov 21, 2023

Contributor

craigrose commented Nov 13, 2023

added a missing config for the WorkerIT
added an integration test to run a process request that will fail
the issue was that the collection name was not set before the process failed
solution was to get the collection name while generating the email message if it was not already set
updated some resource files used by unit tests

craigrose added 5 commits

November 13, 2023 16:30


          generated the collection name when the request fails

40ac4a6


          fix up some unit test resource files

9e9a0dd


          update lambda zips

f5d70d8


          reverted test file

7c6f105


          updated some test files

2ff6222

craigrose requested a review from utas-raymondng

November 14, 2023 02:05

utas-raymondng approved these changes

View reviewed changes

Contributor

utas-raymondng left a comment

LGTM

craigrose merged commit 777d5d6 into master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet