Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cars-monthly-expected.cdl #346

Closed
wants to merge 3 commits into from
Closed

Conversation

vietnguyengit
Copy link
Contributor

Replace killed email address

Replace killed email address
@mhidas
Copy link

mhidas commented Jul 27, 2023

I don't know what the purpose of this file is and how it's being used.
If it's a template for aggregated NetCDF produced by AWS-WPS, then the email should be updated - but so should other references to "eMII" in there ( data_centre, institution, institution_references).
Note also that some of the NetCDF files in the same directory will also have these old attributes in them...

@mhidas
Copy link

mhidas commented Jul 27, 2023

@ggalibert Might be better placed to comment on how these files are used?

@vietnguyengit
Copy link
Contributor Author

Thanks @mhidas I've updated other places in this file

@akashisama
Copy link
Contributor

These are soley test files. I assume the cdl defines what is expected in the resulting netcdf file, which is why the tests are failing on this PR. So we'll either need to fix the test netcdfs or leave the cdl as is with outdated info (which isn't too bad given their just for testing)

@vietnguyengit
Copy link
Contributor Author

so I will revert the changes? @akashisama

@vietnguyengit
Copy link
Contributor Author

oh just simply close this PR

@akashisama akashisama deleted the vietnguyengit-patch-2 branch July 28, 2023 01:25
@vietnguyengit
Copy link
Contributor Author

will reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants