-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated contract to use a single signer' #51
base: master
Are you sure you want to change the base?
Conversation
*/ | ||
function verify(bytes memory _callData, | ||
function replayProtection(address _signer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be called checkAndUpdateReplayProtection
} | ||
|
||
/// @dev Return owner. | ||
function getOwner() internal view returns (address) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this funtion? Cant we just call owner
?
@@ -40,10 +34,16 @@ contract ProxyAccount is ReplayProtection, BatchInternal { | |||
bytes memory _signature) public returns (bool, bytes memory) { | |||
|
|||
// Assumes that ProxyAccountDeployer is ReplayProtection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment out of date?
* @param _replayProtectionAuthority Identify the Replay protection, default is address(0) | ||
* @param _signature Signature from signer | ||
*/ | ||
function getSigner(bytes memory _encodedCallData, bytes memory _replayProtection, address _replayProtectionAuthority, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the chat, I think we should use this everywhere
No description provided.