Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: Incorrect formatting of repo card description #3956 #3962

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sagarbendale2004
Copy link

Description of the Bug

The repository card's description width appears to be inappropriate under certain conditions, leading to an imbalance with the overall padding and layout of the card. This issue makes the card visually inconsistent, potentially affecting the user experience.

Expected Behavior

The description text should maintain a more appropriate width, ensuring a larger space between the text and the card's border. This adjustment will create a more balanced and aesthetically pleasing layout for the repository card.

Proposed Solution

This issue has been addressed by updating the code that generates the repository card. Specifically, the anchor tag now properly wraps the entire card content, including the badge and description. The relevant code changes are as follows:

<a href="https://github.com/${nameWithOwner}" target="_blank" rel="noopener noreferrer">
  // This anchor tag links to the GitHub repository or gist for the card
  ${card.render(`...`)}
</a>

The modification ensures that the description does not extend too far, thus preventing overlap with the card's border.

Proper padding adjustments can be made in the CSS if needed, to ensure that the description aligns well within the card's layout.

By implementing this change, the repository card's description width will be more appropriate, enhancing the overall presentation and usability of the card in the user interface.

Copy link

vercel bot commented Oct 1, 2024

@sagarbendale2004 is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added repo-card Issues related to the pin/repo card. gist-card labels Oct 1, 2024
@sagarbendale2004
Copy link
Author

@anuraghazra please review my changes i fixed this particular issue. and if my changes is well good then please merge my PR as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gist-card repo-card Issues related to the pin/repo card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant