Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add theme nightshade_noir #3593

Closed
wants to merge 1 commit into from

Conversation

MarcosApodaca
Copy link

I want to add Nightshade Noir because, Nightshade Noir exhibits high versatility as it seamlessly integrates with a variety of colors and styles. It can serve as the perfect backdrop to accentuate other colors or design elements, as its softness doesn't overpower other tones.

Nightshade Noir

Copy link

vercel bot commented Jan 16, 2024

@MarcosApodaca is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Jan 16, 2024
Copy link
Contributor

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

Warning

Keep in mind that we already have a vast collection of different themes. To keep their number manageable, we began to add only themes supported by the community. Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up 👍 emojis (see #1935). We expect to see at least 10-15 thumbs up before making a decision to merge your pull request into the master branch. Remember that you can also support themes of other contributors that you liked to speed up their merge.

Warning

Please do not submit a pull request with a batch of themes, since it will be hard to judge how the community will react to each of them. We will only merge one theme per pull request. If you have several themes, please submit a separate pull request for each of them. Situations when you have several versions of the same theme (e.g. light and dark) are an exception to this rule.

Note

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ nightshade_noir

Result: ✔️ All themes are valid.

Details

Nightshade_noir theme preview

title_color: #fff | icon_color: #79ff97 | text_color: #9f9f9f | bg_color: #24211e

Preview Link

Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @MarcosApodaca! Thanks for your interest in our project. I'm closing this pull request because our team recently made a decision to stop addition of new themes to prevent bloating its collection (see #3404). Maybe in future we will move themes into separate themes-provider project and you're welcome to contribute than. Currently you can use card customization options, I will add an example below.

<img src="https://github-readme-stats.vercel.app/api?username=anuraghazra&show_icons=true&title_color=fff&text_color=9f9f9f&icon_color=79ff97&bg_color=24211e" />

@qwerty541 qwerty541 closed this Feb 10, 2024
@MarcosApodaca
Copy link
Author

Oh wow, I get it, I'll keep an eye out. Even so, I appreciate your time in explaining the personalized use to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants