Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to have B+ rank #883

Closed
CrafterKolyan opened this issue Feb 16, 2021 · 14 comments
Closed

Impossible to have B+ rank #883

CrafterKolyan opened this issue Feb 16, 2021 · 14 comments

Comments

@CrafterKolyan
Copy link

Describe the bug
Current rank calculation is broken due to it is not possible to get score more than 51.03597635931825

Expected behavior
Score should be in range [0; 100] so that B+ rank would be obtainable.

Screenshots / Live demo link (paste the github-readme-stats link as markdown image)
image

@CrafterKolyan CrafterKolyan changed the title Impossible to have a B+ rank Impossible to have B+ rank Feb 16, 2021
@stale
Copy link

stale bot commented Mar 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is marked as stale. label Mar 18, 2021
@CrafterKolyan
Copy link
Author

The rating algorithm hasn't changed. It's still impossible to get a B+ rank

@stale stale bot removed the stale Issue is marked as stale. label Mar 18, 2021
@itsjavi
Copy link

itsjavi commented Mar 20, 2021

I only see A+ everywhere. I compared an inactive user with 10 PRs and 0 stars with another one with 2K stars and 220 PRs, both have the same A+ rating. Isn't that weird?

@stale
Copy link

stale bot commented Apr 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is marked as stale. label Apr 19, 2021
@CrafterKolyan
Copy link
Author

Nothing changed, still an issue

@stale stale bot removed the stale Issue is marked as stale. label Apr 19, 2021
@Anequit
Copy link

Anequit commented Jul 24, 2021

I would like to see the possibility of getting F+/-, D+/-, C+/-, and B+/-

@terryzhao127
Copy link

This classification is too rough 😢

@Seggan
Copy link

Seggan commented Oct 10, 2021

A user with 0 of everything is still A+

@rickstaa
Copy link
Collaborator

I think we can close this in favour of #455.

@rickstaa
Copy link
Collaborator

Closed in favour of #455.

@yuuuuuuan
Copy link

impossible

@qwerty541
Copy link
Collaborator

impossible

@yuuuuuuan Currently to have B+ rank you should have approximately the following stats:

Commits: 250
Pull requests: 50
Issues: 25
Reviews: 10
Stars: 50
Followers: 10

@Nicat-dev
Copy link

that mainly about last year contribution because My profile B- right now

@qwerty541
Copy link
Collaborator

that mainly about last year contribution because My profile B- right now

@Nicat-dev That about all time contributions, except commits count. Your profile does not match minimal requirements for B+ rank. You can check which stats you should have for each rank in tests file for rank calculation function: https://github.com/anuraghazra/github-readme-stats/blob/master/tests/calculateRank.test.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants