Replies: 24 comments
-
I'll work on it! |
Beta Was this translation helpful? Give feedback.
-
Or the rank circle could be hidden to make room for the stats. I do like your idea though @Angelk90. |
Beta Was this translation helpful? Give feedback.
-
@Angelk90 Yup! Even better!👍 @nthnchu Keep in mind, the idea is to have both cards be able to go side by side, not for it to be as small as possible. Ideally we'd be able to have the same information displayed, but without unless white space to compact the image. |
Beta Was this translation helpful? Give feedback.
-
What do you think of such a graph instead of what you see below. |
Beta Was this translation helpful? Give feedback.
-
@Angelk90 Yeah that looks kinda bad in my opinion... The current compact lang graph that looks just like github's is very very nice, and this pie chart kinda loses the pleasing ascetic of the current compact one. Additionally, this concept pie chart you have only displays the rank, which as I see it, is the most useless information on the card compared to the actual stats... Personally I really like your original concept the best. Overall I think mixing the two graphs isn't a great idea either, since they both display different information that's good in it's own way. Especially since some people may just want a compact stats card, but not want it mixed with languages. I'm curious what other people's thoughts on this pie chart are, though! |
Beta Was this translation helpful? Give feedback.
-
I like this Pie chart, but i don't think it would look good if we mix it up with stats card, maybe we can make it a new layout option in the Languages card |
Beta Was this translation helpful? Give feedback.
-
Issue with this compact card is people would get really confused with just the numbers, and it also looks too much cramped IMO. @HPaulson's original card is better because it shows some context of what those numbers means. |
Beta Was this translation helpful? Give feedback.
-
@anuraghazra Also for This Comment, I think that the numbers appear more clean actually... Since most github users are going to know the icons meaning, since they are used around the platform and are quite universal here. Only one that could get confusing possibly is the commit icon in my opinion. I think it's a bit cleaner without the words however since they are all aligned where the words have different lengths and looks kinda strange when compacted I think. Both work just fine, though. Finally, I do agree that It looks a bit crammed, not sure how we could fix this without adding unnecessary white space and taking away it's compact-ability. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
You can hide the rank circle |
Beta Was this translation helpful? Give feedback.
-
No, I'm not talking about the centered rank on the pie chart. Just the pie chart in the langs card. |
Beta Was this translation helpful? Give feedback.
-
Ah okay, I'll mark my comment as off-topic then haha. Didn't see that option in docs, sorry about that! |
Beta Was this translation helpful? Give feedback.
-
Yeah as I mentioned later in that comment-
What I meant there was just that it seemed the intention of the concept was to merge the rank from stats & lang cards, which I thought was a bit poor. Having just a pie chart for langs is a great idea like I mentioned, however I'll mention again that the current compact one is a pie chart just in a line and not a circle, so it may be a bit repetitive. However if people prefer the circle shape, then it's a great idea. Having more options isn't a bad thing! All I was saying is that mixing the two I think is poor, but if that isn't the intention, than I think that could be a great idea too! |
Beta Was this translation helpful? Give feedback.
-
Also, I have some other possible card ideas that I think could possibly excel this project... Should I make a new issue for them or just change the title here to "Possible card ideas" and leave it as more of an open discussion for more possible ideas, rather than just the compact stats card, since we're already talking about other card ideas such as the pie chart? |
Beta Was this translation helpful? Give feedback.
-
Of course do it! |
Beta Was this translation helpful? Give feedback.
-
No it won't be repetitive, it would be just a stylistic choice of which type of design users would like to use. |
Beta Was this translation helpful? Give feedback.
-
Additionally, I had an idea about having a card to show recent activity and contributions - I used to use this repo to update a pinned gist to do so, however I think that with the addition of readme it could be much much more improved by being an image, rather than being text in a gist; The design could be much more improved, and it could be a cool card to add! What are everyone's thoughts on something like this? Also, I'm going to edit the initial comment on this thread to include the ideas we've shared so far. |
Beta Was this translation helpful? Give feedback.
-
Just a quick update on this, I did actually make some changes to the stats card to see how this would come out, and I think it looks great! @anuraghazra What are your thoughts? Changes- 34 <text class="stat bold" ${labelOffset} y="12.5">${label}:</text>
+ 35 ${labelOffset}
- 37 x="${shiftValuePos ? (showIcons ? 200 : 170) : 150}"
+ 40 <text class="stat bold" x="60" y="12.5">${label}</text>
- 85 label: "Total Stars",
+ 85 label: "Stars Received",
- 91 label: `Total Commits${
+ 91 label: `Commits${
- 99 label: "Total PRs",
+ 99 label: "PRs",
- 105 label: "Total Issues",
+ 105 label: "Issues",
- 111 label: "Contributed to",
- 134 hide_rank ? 0 : 150
+ 134 hide_rank ? 0 : 75
- 141 hide_rank ? 0 : 75
+ 141 transform="translate(300, ${height / 2 - 50})">
- 171 width: 495,
+ 171 width: 350, |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
@Angelk90 This thread is just a basic discussion of different possible card ideas- if you want one added, I'd suggest opening a PR & creating it! |
Beta Was this translation helpful? Give feedback.
-
Height of Top Languages Card should be equal to the height of GitHub Stats Card, so that it looks symmetrical when aligned side-by-side. |
Beta Was this translation helpful? Give feedback.
-
I decided to not do it |
Beta Was this translation helpful? Give feedback.
-
I will put this here for future reference. This discussion is meant to be a place where the community can ask for feedback about a possible card idea from the @github-readme-stats core team and the community before creating a feature request or PR. We have not yet implemented any of the features requested by @Angelk90 in #945 (comment).
|
Beta Was this translation helpful? Give feedback.
-
Discussion of new possible card ideas & options for existing cards!
Possible Card Ideas:
Compact Stats Card
Pie chart language card
Beta Was this translation helpful? Give feedback.
All reactions