Don't understand this code

[Zo-Bro-23]

github-readme-stats/src/cards/stats-card.js

Lines 295 to 300 in 0ff426d

	if (key === "commits") {
	return `${i18n.t("statcard.commits")} ${
	include_all_commits ? "" : `in ${new Date().getFullYear()}`
	} : ${totalStars}`;
	}
	return `${STATS[key].label}: ${STATS[key].value}`;

I don't understand this code. First of all, why are we using "Total commits" label and adding totalStars value? Second of all, why do we even need a special case for commits? STATS.commits.label and STATS.commits.value will work right?

[Zo-Bro-23]

@rickstaa any idea why this is?

[rickstaa]

Last time I checked it did not 🤔

So there's nothing wrong with this code, per se. It just does the same thing twice. I've removed this in #2409 though, so it'll be fixed when that gets merged.

Can you link to me where you think the year is already added? 🤔

[rickstaa]

BTW @anuraghazra I think already send you a collaboration invite. 🚀

[Zo-Bro-23]

Can you link to me where you think the year is already added? 🤔

github-readme-stats/src/cards/stats-card.js

Lines 128 to 142 in 0ff426d

	const STATS = {
	stars: {
	icon: icons.star,
	label: i18n.t("statcard.totalstars"),
	value: totalStars,
	id: "stars",
	},
	commits: {
	icon: icons.commits,
	label: `${i18n.t("statcard.commits")}${
	include_all_commits ? "" : ` (${new Date().getFullYear()})`
	}`,
	value: totalCommits,
	id: "commits",
	},

[Zo-Bro-23]

BTW @anuraghazra I think already send you a collaboration invite. 🚀

Didn't get an email, but maybe it'll take time!

[rickstaa]

Can you link to me where you think the year is already added? 🤔

github-readme-stats/src/cards/stats-card.js

Lines 128 to 142 in 0ff426d

	const STATS = {
	stars: {
	icon: icons.star,
	label: i18n.t("statcard.totalstars"),
	value: totalStars,
	id: "stars",
	},
	commits: {
	icon: icons.commits,
	label: `${i18n.t("statcard.commits")}${
	include_all_commits ? "" : ` (${new Date().getFullYear()})`
	}`,
	value: totalCommits,
	id: "commits",
	},

Good catch. One of those can be removed.👍