Enable consistent return eslint rule (#3065)

anuraghazra · Aug 12, 2023 · 135176f · 135176f
1 parent c394ea3
commit 135176f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -38,7 +38,7 @@
         //     "setWithoutGet": true
         // }],
         // "block-scoped-var": "warn",
-        // "consistent-return": "error",
+        "consistent-return": "error",
         // "curly": "error",
         // "default-case": "warn",
 

diff --git a/scripts/preview-theme.js b/scripts/preview-theme.js
@@ -113,7 +113,7 @@ const isPreviewComment = (inputs, comment) => {
  * @param {string} owner Owner of the repository.
  * @param {string} repo Repository name.
  * @param {string} commenter Comment author.
- * @returns {Object} The GitHub comment object.
+ * @returns {Object | undefined} The GitHub comment object.
  */
 const findComment = async (octokit, issueNumber, owner, repo, commenter) => {
   const parameters = {
@@ -141,6 +141,8 @@ const findComment = async (octokit, issueNumber, owner, repo, commenter) => {
       debug(`No theme preview comment found.`);
     }
   }
+
+  return undefined;
 };
 
 /**

diff --git a/src/fetchers/repo-fetcher.js b/src/fetchers/repo-fetcher.js
@@ -109,6 +109,8 @@ const fetchRepo = async (username, reponame) => {
       starCount: data.organization.repository.stargazers.totalCount,
     };
   }
+
+  throw new Error("Unexpected behavior");
 };
 
 export { fetchRepo };