Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get wrong anchor when a node is invisible #4313

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

leondt1
Copy link
Collaborator

@leondt1 leondt1 commented May 21, 2024

#4264
显示隐藏的节点后,边的锚点位置计算错误

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. labels May 21, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented May 21, 2024

👋 @leondt1

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added PR(fix) :bug: Bug Fix pkg:x6 labels May 21, 2024
@leondt1 leondt1 requested a review from NewByVector May 21, 2024 03:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 10.35%. Comparing base (0bbff8f) to head (b4a353d).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4313   +/-   ##
=======================================
  Coverage   10.35%   10.35%           
=======================================
  Files         180      180           
  Lines       10578    10578           
  Branches     2577     2577           
=======================================
  Hits         1095     1095           
  Misses       9394     9394           
  Partials       89       89           
Flag Coverage Δ
x6 10.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/x6/src/registry/node-anchor/middle-side.ts 8.10% <0.00%> (ø)
packages/x6/src/registry/node-anchor/orth.ts 16.00% <0.00%> (ø)
packages/x6/src/registry/node-anchor/bbox.ts 58.82% <0.00%> (ø)

@leondt1 leondt1 merged commit c5d19fd into master May 21, 2024
14 checks passed
@leondt1 leondt1 deleted the fix/anchor-problem branch May 21, 2024 05:44
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels May 21, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented May 21, 2024

👋 @leondt1

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:x6 PR(fix) :bug: Bug Fix PR: merged PR has merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants