Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toJSON({ diff: true })没有达到预期效果 #4297 #4299

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: toJSON({ diff: true })没有达到预期效果 #4297 #4299

merged 1 commit into from
Jun 6, 2024

Conversation

qiufeihong2018
Copy link
Contributor

@qiufeihong2018 qiufeihong2018 commented May 12, 2024 •
edited
Loading

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented May 12, 2024

@qiufeihong2018 Please provide us with more info about this pull request.

@x6-bot x6-bot bot added needs-more-info PR: unreviewed PR does not have any reviews. labels May 12, 2024
@NewByVector NewByVector merged commit a431f52 into antvis:master Jun 6, 2024
16 checks passed
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewByVector NewByVector NewByVector approved these changes

Assignees
No one assigned
Labels
needs-more-info PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiufeihong2018 @NewByVector