Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust button tool matrix #4276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

orientMoon
Copy link
Contributor

@orientMoon orientMoon commented Apr 25, 2024

Description

节点tools附着在节点元素上时,tools在计算matrix的tx、ty时需要以节点为原点

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot
Copy link
Contributor

x6-bot bot commented Apr 25, 2024

@orientMoon Please provide us with more info about this pull request.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. pkg:x6 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 10.35%. Comparing base (12ca0e1) to head (4d03951).
Report is 72 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4276      +/-   ##
==========================================
- Coverage   10.37%   10.35%   -0.02%     
==========================================
  Files         180      180              
  Lines       10542    10572      +30     
  Branches     2566     2574       +8     
==========================================
+ Hits         1094     1095       +1     
- Misses       9359     9388      +29     
  Partials       89       89              
Flag Coverage Δ
x6 10.35% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/registry/tool/button.ts 10.44% <0.00%> (ø)

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info pkg:x6 PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants