Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: panning modifiers add space #4166

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

cnyballk
Copy link
Contributor

在 panning modifiers 添加 space ,想只在 panning 中修改,所以想 isMatch 中的事件参数直接添加 spaceKey 直接进行判断了

@x6-bot x6-bot bot added pkg:x6 PR: unreviewed PR does not have any reviews. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (cf4cf1f) 10.36% compared to head (735df0e) 10.36%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4166   +/-   ##
=======================================
  Coverage   10.36%   10.36%           
=======================================
  Files         180      180           
  Lines       10563    10563           
  Branches     2572     2572           
=======================================
  Hits         1095     1095           
  Misses       9379     9379           
  Partials       89       89           
Flag Coverage Δ
x6 10.36% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/graph/panning.ts 4.34% <0.00%> (ø)

@cnyballk cnyballk changed the title Feat panning modifiers add space feat: panning modifiers add space Jan 19, 2024
@x6-bot x6-bot bot added PR: reviewed-approved PR has reviewed and got Approve from everyone. and removed PR: unreviewed PR does not have any reviews. labels Jan 24, 2024
@NewByVector NewByVector merged commit fe3b7ac into antvis:master Jan 24, 2024
19 checks passed
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: reviewed-approved PR has reviewed and got Approve from everyone. labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:x6 PR: merged PR has merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants