Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attr的path、polygon 增加相对refBBox的偏移 #4149

Closed
wants to merge 1 commit into from

Conversation

cuidong626
Copy link
Contributor

@cuidong626 cuidong626 commented Jan 11, 2024

…pOffset 增加针对refBBox的相对平移

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. pkg:x6 labels Jan 11, 2024
@cuidong626
Copy link
Contributor Author

#4134

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f29fe2d) 10.36% compared to head (ca057f2) 10.36%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4149   +/-   ##
=======================================
  Coverage   10.36%   10.36%           
=======================================
  Files         180      180           
  Lines       10563    10563           
  Branches     2572     2572           
=======================================
  Hits         1095     1095           
  Misses       9379     9379           
  Partials       89       89           
Flag Coverage Δ
x6 10.36% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/registry/attr/ref.ts 39.17% <0.00%> (ø)

@cuidong626 cuidong626 closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:x6 PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant