Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-shape): remove deprecated Vue from import #4099

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

kingyue737
Copy link
Contributor

Description

Direct import markRaw, Fragment and Teleport from vue-demi

Motivation and Context

fix #4096

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Dec 14, 2023

👋 @kingyue737

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@kingyue737 kingyue737 changed the title fix(vue-shape): remove Vue from named export fix(vue-shape): remove deprecated Vue from import Dec 14, 2023
@x6-bot x6-bot bot added PR: reviewed-approved PR has reviewed and got Approve from everyone. and removed PR: unreviewed PR does not have any reviews. labels Jan 9, 2024
@NewByVector NewByVector merged commit fa66d3a into antvis:master Jan 9, 2024
20 checks passed
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: reviewed-approved PR has reviewed and got Approve from everyone. labels Jan 9, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented Jan 9, 2024

👋 @kingyue737

Congrats on merging your first pull request! 🎉🎉🎉

@kingyue737 kingyue737 deleted the patch-1 branch January 9, 2024 02:54
@XeniaLu
Copy link

XeniaLu commented Jan 17, 2024

@NewByVector @kingyue737 可以发布新版本吗?

@kingyue737
Copy link
Contributor Author

@XeniaLu you can use patch-package or https://pnpm.io/cli/patch if you use pnpm to manually apply this fix before the maintainer has time to release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue-demi does not provide an export named 'Vue'
3 participants