feat: selection's pointerEvents support function type #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x6-bot
bot
added
feature
NewByVector
requested changes
Jan 9, 2024
| @@ -126,7 +126,10 @@ export class SelectionImpl extends View<SelectionImpl.EventArgs> { | |||
| const { ui, selection, translateBy, snapped } = options | |||
|
|
|||
| const allowTranslating = | |||
| (showNodeSelectionBox !== true || pointerEvents === 'none') && | |||
| (showNodeSelectionBox !== true || | |||
There was a problem hiding this comment.
不好意思，这么久才来 review 代码，注意到两个地方都有相似的判断，可以提取成一个函数。
x6-bot
bot
added
PR: reviewed-changes-requested
NewByVector
added
PR: unreviewed
x6-bot
bot
added
PR: unreviewed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4067 +/- ##
==========================================
- Coverage 10.37% 10.36% -0.02%
==========================================
Files 180 180
Lines 10542 10563 +21
Branches 2566 2572 +6
==========================================
+ Hits 1094 1095 +1
- Misses 9359 9379 +20
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. |
NewByVector
approved these changes
Jan 24, 2024
x6-bot
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"pointerEvents",one of the plugin "Selection"'s configuation,supporting function type
see #4062
"pointerEvents",one of the plugin "Selection"'s configuation,supporting function type
see #4062
Types of changes
Self Check before Merge