Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stencil addGroup #4066

Closed
wants to merge 1 commit into from
Closed

Conversation

sunven
Copy link

@sunven sunven commented Nov 30, 2023

Description

bugfix: #4007

Motivation and Context

分组信息通常由服务端返回,那么会先调用stencil.addGroup, 再调用stencil.load来完成分组的显示, addGroup方法未监听mousedown事件,导致节点无法拖拽。

examples/x6-example-features 中补充了示例

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. fix labels Nov 30, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 30, 2023

👋 @sunven

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added the PR: unreviewed PR does not have any reviews. label Nov 30, 2023
@@ -169,7 +169,11 @@ export class Stencil extends View implements Graph.Plugin {
} else {
this.options.groups = groups
}
groups.forEach((group) => this.initGroup(group))
groups.forEach((group) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉,这么久才来 Review 代码,这里没有考虑 removeGroup 的时候清除事件监听,我重新提一个 PR。

@NewByVector NewByVector closed this Jan 2, 2024
@x6-bot x6-bot bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR: reviewed-changes-requested PR has reviewed and got Change request event. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants