Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete return selection #4026

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

orientMoon
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 10, 2023

@orientMoon Please provide us with more info about this pull request.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #4026 (d8887ee) into master (1c2d637) will increase coverage by 0.04%.
Report is 20 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4026      +/-   ##
==========================================
+ Coverage   10.33%   10.37%   +0.04%     
==========================================
  Files         180      180              
  Lines       10528    10544      +16     
  Branches     2568     2567       -1     
==========================================
+ Hits         1088     1094       +6     
- Misses       9351     9361      +10     
  Partials       89       89              
Flag Coverage Δ
x6 10.37% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

@NewByVector NewByVector merged commit 0178e48 into antvis:master Nov 13, 2023
16 checks passed
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants