fix: fix invalid history on vertices tool (#3765)

* fix: fix invalid history on vertices tool * chore: release @antv/[email protected]
antvis · Jul 12, 2023 · bc81583 · bc81583
1 parent 7eb9748
commit bc81583
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/packages/x6-plugin-scroller/package.json b/packages/x6-plugin-scroller/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/x6-plugin-scroller",
-  "version": "2.0.9",
+  "version": "2.0.10",
   "description": "scroller plugin for X6",
   "main": "lib/index.js",
   "module": "es/index.js",

diff --git a/packages/x6/package.json b/packages/x6/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/x6",
-  "version": "2.11.3",
+  "version": "2.11.5",
   "description": "JavaScript diagramming library that uses SVG and HTML for rendering",
   "main": "lib/index.js",
   "module": "es/index.js",

diff --git a/packages/x6/src/registry/tool/vertices.ts b/packages/x6/src/registry/tool/vertices.ts
@@ -165,6 +165,13 @@ export class Vertices extends ToolsView.ToolItem<EdgeView, Vertices.Options> {
     }
   }
 
+  protected stopBatch(vertexAdded: boolean) {
+    this.cell.stopBatch('move-vertex', { ui: true, toolId: this.cid })
+    if (vertexAdded) {
+      this.cell.stopBatch('add-vertex', { ui: true, toolId: this.cid })
+    }
+  }
+
   protected onHandleChanged({ e }: Vertices.Handle.EventArgs['changed']) {
     const options = this.options
     const edgeView = this.cellView
@@ -174,6 +181,7 @@ export class Vertices extends ToolsView.ToolItem<EdgeView, Vertices.Options> {
     }
 
     if (!options.removeRedundancies) {
+      this.stopBatch(this.eventData(e).vertexAdded)
       return
     }
 
@@ -188,11 +196,7 @@ export class Vertices extends ToolsView.ToolItem<EdgeView, Vertices.Options> {
 
     this.blur()
 
-    edgeView.cell.stopBatch('move-vertex', { ui: true, toolId: this.cid })
-
-    if (this.eventData(e).vertexAdded) {
-      edgeView.cell.stopBatch('add-vertex', { ui: true, toolId: this.cid })
-    }
+    this.stopBatch(this.eventData(e).vertexAdded)
 
     const { e: evt, x, y } = this.getMouseEventArgs(e)