Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old amap v1 and v2 #2435

Merged
merged 12 commits into from
May 6, 2024
Merged

refactor: remove old amap v1 and v2 #2435

merged 12 commits into from
May 6, 2024

Conversation

lvisei
Copy link
Member

@lvisei lvisei commented Apr 29, 2024

🤔 这个变动的性质是?

  • 重构

相关 Issues

#2411

💡 需求背景和解决方案

旧版高德地图方案移除,高德 V2 地图接入升级为统一的视口同步

  • 高德 V1 Map 移除,删除内置坐标系 P20 和 P20_OFFSET,删除 shader 里的投影逻辑
  • 高德 V2 旧方案 Map 移除,删除内置坐标系 P20_2,删除数据流流程植入逻辑、shader 里的投影逻辑
  • l7-three 支持新版高德相机同步
  • 移除部分 layer 不必要的剔除逻辑 f66bb79 (#2435)

后续 Actions

  • 3D heatmap 抖动

@lvisei
Copy link
Member Author

lvisei commented Apr 29, 2024

代码量减少了 3.8% (1867 行,49231 -> 47364 )

@lvisei lvisei changed the title refactor: remove old amap v1 and v2 「WIP」refactor: remove old amap v1 and v2 Apr 29, 2024
@lvisei lvisei changed the title 「WIP」refactor: remove old amap v1 and v2 refactor: remove old amap v1 and v2 Apr 30, 2024
@lvisei
Copy link
Member Author

lvisei commented Apr 30, 2024

发现 l7-three 使用 mapbox 为底图时,并没有支持

@lvisei
Copy link
Member Author

lvisei commented Apr 30, 2024

发现 l7-three 使用 mapbox 为底图时,并没有支持

https://docs.mapbox.com/mapbox-gl-js/example/add-3d-model/

Copy link
Contributor

@lzxue lzxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大致看了一下代码,问题不大,重点还需要看一下已有demo 是否表现一致,新的模式可能影响法线方向的问题,会影响光照和高度,宽度相关的计算

重点关注:

  • 3D 点图层,面图层高度和光照效果是否表现一致
  • 线图层: wall lineheight 是否表现一致
  • flow line 箭头问题
  • 3D heatmap 是否抖动

另外考虑一下版本发布的,是否发布 3.0 做breakchange 升级, Map 升级之后是否把 L7-Maps 抽离出来, L7 内部不引用Map,

@lvisei
Copy link
Member Author

lvisei commented Apr 30, 2024

另外考虑一下版本发布的,是否发布 3.0 做breakchange 升级, Map 升级之后是否把 L7-Maps 抽离出来, L7 内部不引用Map,

Maps 抽离出来,要发大版本,感觉还是得地图模块彻底重构后才合适,现阶段拆出去,就是一个包放到外面的拆分,彻底重构还有以下事情:

  • L7 内置默认地图视图实现
  • L7 主动同步三方地图能力,L7 UI 组件容器逻辑调整
  • 三方地图插件迁移实现

@lvisei lvisei changed the title refactor: remove old amap v1 and v2 「WIP」refactor: remove old amap v1 and v2 Apr 30, 2024
@lvisei
Copy link
Member Author

lvisei commented May 6, 2024

  • 3D 点图层,面图层高度和光照效果是否表现一致

之前部分 shape 错误将光照放在投影计算之前,已订正。现光照效果与底图无关,且一致。

@lvisei
Copy link
Member Author

lvisei commented May 6, 2024

  • 线图层: wall lineheight 是否表现一致
  • flow line 箭头问题

一致

@lvisei
Copy link
Member Author

lvisei commented May 6, 2024

  • 3D heatmap 是否抖动

3D 热力一直存在高层级抖动,其抖动原因是纹理计算过程中精度丢失

相关 issues

@lvisei lvisei changed the title 「WIP」refactor: remove old amap v1 and v2 refactor: remove old amap v1 and v2 May 6, 2024
@lvisei lvisei merged commit 969b533 into beta May 6, 2024
10 checks passed
@lvisei lvisei deleted the refactor/remove-amap2 branch May 6, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants